Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide buildpack create command #1534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Provide buildpack create command #1534

wants to merge 1 commit into from

Conversation

AidanDelaney
Copy link
Member

@AidanDelaney AidanDelaney commented Oct 24, 2022 •
edited
Loading

Implement RFC 212 to provide a more general mechanism to provide project scaffolding for new buildpacks.

Summary

Uses https://github.com/AidanDelaney/scafall to implement RFC 212.

Defaults to bash subpath of https://github.com/AidanDelaney/cnb-buildpack-templates to provide the default template.

Open Questions

  1. Do we want to move scafall to the buildpacks org?
  2. Do we want to move cnb-buildpack-templates to the buildpacks org (and maybe rename to cnb-templates)?

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

@AidanDelaney AidanDelaney requested a review from a team as a code owner October 24, 2022 09:52
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Oct 24, 2022
@github-actions github-actions bot added this to the 0.28.0 milestone Oct 24, 2022
@AidanDelaney AidanDelaney marked this pull request as draft October 24, 2022 09:52
@AidanDelaney
Copy link
Member Author

Depends on buildpacks-community/scafall#2 will undraft when that (and some subsequent changes) land.

@natalieparellano natalieparellano mentioned this pull request Dec 2, 2022
Open
3 tasks
@dfreilich dfreilich modified the milestones: 0.28.0, 0.29.0 Jan 8, 2023
@natalieparellano natalieparellano mentioned this pull request Feb 16, 2023
Open
1 task
@AidanDelaney
Copy link
Member Author

This draft can be driven using

go run cmd/pack/main.go buildpack create -t [email protected]:AidanDelaney/cnb-templates.git

We don't yet have a https://github.com/buildpacks/templates repo that contains a template (awaiting buildpacks/templates#1). A bare mkdir foo && cd foo && go run ../cmd/pack/main.go buildpack create correctly populates the directory with a LICENCE file that is contained in https://github.com/buildpacks/templates.

@dfreilich dfreilich modified the milestones: 0.29.0, 0.30.0 Mar 26, 2023
@natalieparellano natalieparellano modified the milestones: 0.30.0, 0.31.0 May 19, 2023
@github-actions github-actions bot modified the milestones: 0.31.0, 0.30.0 Jun 20, 2023
@jjbustamante jjbustamante modified the milestones: 0.30.0, 0.31.0 Jun 21, 2023
@github-actions github-actions bot modified the milestones: 0.31.0, 0.30.0 Jun 28, 2023
@AidanDelaney AidanDelaney force-pushed the implement-pack-create branch 2 times, most recently from 7445046 to 150c2ae Compare June 28, 2023 05:25
@AidanDelaney AidanDelaney marked this pull request as ready for review June 28, 2023 05:27
@jjbustamante jjbustamante modified the milestones: 0.30.0, 0.31.0 Jun 30, 2023
@github-actions github-actions bot modified the milestones: 0.31.0, 0.30.0 Jul 4, 2023
@jjbustamante jjbustamante modified the milestones: 0.30.0, 0.31.0 Jul 4, 2023
@natalieparellano
Copy link
Member

@AidanDelaney what's the status of this one?

@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante added experimental Issue or PR refers to an experimental feature. and removed type/chore Issue that requests non-user facing changes. labels Nov 7, 2023
@jjbustamante
Copy link
Member

@AidanDelaney I think we are good with this one, right? the dependencies:

Can you rebase to the latest? there is a problem with the Windows Acceptance Test (LCOW) but I am trying to solve that

@natalieparellano natalieparellano modified the milestones: 0.33.0, 0.34.0 Dec 13, 2023
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Feb 8, 2024
@jjbustamante jjbustamante removed the type/chore Issue that requests non-user facing changes. label Feb 8, 2024
jjbustamante
jjbustamante reviewed Feb 8, 2024
View reviewed changes
go.mod Outdated
github.com/docker/cli v24.0.6+incompatible
github.com/docker/docker v24.0.7+incompatible
github.com/docker/go-connections v0.4.0
)
Copy link
Member

@jjbustamante jjbustamante Feb 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here you are using older versions for

github.com/docker/cli v24.0.7+incompatible
github.com/docker/go-connections v0.5.0

@codecov Codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (2df4445) to head (c61741a).
Report is 250 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
+ Coverage   78.96%   79.53%   +0.57%     
==========================================
  Files         176      178       +2     
  Lines       13246    13314      +68     
==========================================
+ Hits        10459    10588     +129     
+ Misses       2119     2053      -66     
- Partials      668      673       +5
Flag Coverage Δ
os_linux 78.46% <50.00%> (-0.14%) ⬇️
os_macos 76.18% <50.00%> (-0.11%) ⬇️
os_windows 78.92% <50.00%> (+0.62%) ⬆️
unit 79.53% <50.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Feb 8, 2024
@AidanDelaney
Provide buildpack create command
c61741a 
Implement RFC 212 to provide a more general mechanism to provide
project scaffolding for new buildpacks.

Signed-off-by: Aidan Delaney <[email protected]>
@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.35.0 Mar 8, 2024
@natalieparellano
Copy link
Member

Any further updates here?

@natalieparellano natalieparellano modified the milestones: 0.35.0, 0.36.0 Jul 9, 2024
@AidanDelaney
Copy link
Member Author

Oh! I thought this was merged months ago. Sorry. Let's have a quick chat about this in our weekly catchup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbustamante jjbustamante jjbustamante left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
experimental Issue or PR refers to an experimental feature. type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AidanDelaney @natalieparellano @jjbustamante @dfreilich